Update to library template #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbolic links present a problem, at least for "1ES PT".
Co-authored-by: Andrew Arnott <andrew.arnott@microsoft.com>
Update the other 4 entrypoints for 1ES PT
…tps://github.com/microsoft/codecoverage) from 17.9.6 to 17.10.1.- [Commits](https://github.com/microsoft/codecoverage/commits)---updated-dependencies:- dependency-name: dotnet-coverage dependency-type: direct:production update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com> * Bump dotnet-coverage from 17.9.6 to 17.10.1 Bumps [dotnet-coverage](https://github.com/microsoft/codecoverage) from 17.9.6 to 17.10.1. - [Commits](https://github.com/microsoft/codecoverage/commits) --- updated-dependencies: - dependency-name: dotnet-coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
By default the NUGET_PACKAGES path has a trailing slash. In our override, we should do this as well or the msbuild property that gets generated is missing the slash, which can break some builds. This follows the pattern in 9805678, which only applied to one of the locations that in the microbuild branch we must change.
This avoids a pipeline break due to a Microbuild pipeline template injected telemetry task.
Finishes what bb38a72 started
These need to be set before we have a chance to run our variable ps1 scripts.
Bumps [dotnet-coverage](https://github.com/microsoft/codecoverage) from 17.10.1 to 17.10.2. - [Commits](https://github.com/microsoft/codecoverage/commits) --- updated-dependencies: - dependency-name: dotnet-coverage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
It's disabled by default, but is easy to turn on.
By requiring opt-in to sign on mac/linux, we remove the need for signing re-approval on pipelines that are already signing. It also avoids signing binaries that typically will not ship anyway.
These are redundant with those injected by 1ES PT.
CodeQL is injected by default by the 1ES PT templates now, so we don't need this variable.
Self-updating workflow updates
Compile with C# language version 13
Fix to avoid deprecation warning
Workaround github's protections for workflow changes in GitHub Actions
ttstanley
force-pushed
the
users/tevinstanley/updatelibrarytemplate
branch
from
7e98416 to
fa2ee1e
Compare
adrianvmsft
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.