This repository was archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 124
ESLint added, integration with prettier (need testing, suggestions) #104
Open
runofthemillgeek
wants to merge
4
commits into
microsoft:master
Choose a base branch
from
runofthemillgeek:eslint-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": "airbnb-base", | ||
|
|
||
| "env": { | ||
| "browser": true, | ||
| "node": true | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| { | ||
| "editor.formatOnSave": true | ||
| "editor.formatOnSave": true, | ||
|
|
||
| "javascript.format.enable": false, | ||
|
|
||
| "prettier.eslintIntegration": true, | ||
|
|
||
| "[html]": { | ||
| "editor.formatOnSave": false | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,22 @@ | ||
| var $body = document.body; | ||
| var $themeBtns = document.querySelectorAll(".js-theme-button"); | ||
| const $body = document.body; | ||
| const $themeBtns = document.querySelectorAll('.js-theme-button'); | ||
|
|
||
| $themeBtns[0].setAttribute("disabled", true); | ||
| $themeBtns[0].setAttribute('disabled', true); | ||
|
|
||
| $themeBtns.forEach(function(ele) { | ||
| ele.onclick = function(e) { | ||
| var selectedName = e.target.value; | ||
| $themeBtns.forEach((ele) => { | ||
| const element = ele; | ||
|
|
||
| $themeBtns.forEach(function(ele) { | ||
| var themeName = ele.value; | ||
| element.onclick = function onClick(e) { | ||
| const selectedName = e.target.value; | ||
|
|
||
| $themeBtns.forEach((btn) => { | ||
| const themeName = btn.value; | ||
| if (themeName === selectedName) return; | ||
| $body.classList.remove("js-theme-" + themeName); | ||
| ele.removeAttribute("disabled"); | ||
| $body.classList.remove(`js-theme-${themeName}`); | ||
| ele.removeAttribute('disabled'); | ||
| }); | ||
|
|
||
| $body.classList.add("js-theme-" + selectedName); | ||
| ele.setAttribute("disabled", true); | ||
| $body.classList.add(`js-theme-${selectedName}`); | ||
| ele.setAttribute('disabled', true); | ||
| }; | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer simple and less opinionated
eslint:recommendedin this project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I would leave all formatting on
Prettierwithout any ESLint overrides, so if you add https://github.com/prettier/eslint-config-prettier as next config it overrides any rules that Prettier uses.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prichodko Yeah, I think
eslint:recommendedwould be a far less aggressive pick. Hm, I didn't pickeslint-config-prettierbecause it might class with Airbnb but if we're going to lean more on Prettier, then it's desirable I guess.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's why I am trying to make a clear distinction between ESLint (catching bugs) and Prettier (code style), because it makes the whole configuration much easier.