Skip to content

Fixed fonts#999

Open
ElliotWood wants to merge 1 commit intomicrosoft:mainfrom
ElliotWood:bugfix/fonts
Open

Fixed fonts#999
ElliotWood wants to merge 1 commit intomicrosoft:mainfrom
ElliotWood:bugfix/fonts

Conversation

@ElliotWood
Copy link

Summary of changes 🔍
Fixed font rendering issues by updating FluentUI React dependency.

Testing 🧪

  • Verify fonts are loading correctly across all components
  • Test in multiple browsers to ensure consistent font rendering
  • Check that no visual regressions occurred from the dependency update
    (Partial: everything looks centered but doesnt appear to be due to this change?)

Technical Details:

  • Updated @fluentui/react to version ^8.123.0 which resolves the underlying issue where older font references were pointing to an expired CDN endpoint.
  • Root Cause:
  • Previous FluentUI version was referencing fonts from a CDN that had expired, causing font loading failures.
  • Solution:
  • The newer FluentUI version includes updated font references that point to active CDN endpoints.

image

@ElliotWood
Copy link
Author

@msnyder-msft Hey mate if you get a sec to review that'd be awesome

Copy link
Collaborator

@msnyder-msft msnyder-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution.

@pasanchMSFT
Copy link
Collaborator

@ElliotWood Our build is now fixed, if you pull latest and push that update, we'll be able to merge this. Apologies for the inconvenience and thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants