Make building the ifc tool optional #109
Conversation
That is a good default. The IFC SDK should be thought of as as you would think of a compiler framework like Clang+LLVM - set of executables and libraries. |
| install( | ||
| TARGETS ifc | ||
| RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}" | ||
| ) |
There was a problem hiding this comment.
Yes, sorry, the same thing happened to me two days ago with other changes, where I was in C++-CMake syntax mix mode rather than plain CMake syntax mode 😅
There was a problem hiding this comment.
Addition: Undecided whether to indent with 2 or 4 tabs; this does not seem to be consistent across the CMake files.
There was a problem hiding this comment.
Yes, sorry, the same thing happened to me two days ago with other changes, where I was in C++-CMake syntax mix mode rather than plain CMake syntax mode 😅
:-)
I would have expected a local build to catch it.
SunBlack
force-pushed
the
optional_ifc
branch
from
f589195 to
3f8735a
Compare
2 participants
When updating the vcpkg package from 0.43.1 to 0.43.5, the CI failed because the ifc tool is now also being built, while vcpkg only expects libraries by default. Therefore, add an option to not build the tool. I set the default to
ONbecause otherwise I would have to adjust the workflow so that it continues to be built here in the CI, where I don't know what is preferred here (even though I prefer it when only a minimal set is active by default in CMake, as many people probably forget to deactivate the extra tools in their CIs).