Skip to content

Conversation

@LuniaKunal
Copy link

@LuniaKunal LuniaKunal commented Aug 13, 2024

This is my first contribution @ksaur. Tried to Fix issue #766. Sorry for new Pull request.

@LuniaKunal LuniaKunal closed this Aug 13, 2024
@LuniaKunal LuniaKunal deleted the fix#766 branch August 13, 2024 07:06
@LuniaKunal LuniaKunal restored the fix#766 branch August 13, 2024 07:06
@LuniaKunal LuniaKunal reopened this Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (d2aa5dc) to head (8dc104d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   89.95%   87.50%   -2.45%     
==========================================
  Files          80       76       -4     
  Lines        4697     4625      -72     
  Branches      864      864              
==========================================
- Hits         4225     4047     -178     
- Misses        269      375     +106     
  Partials      203      203              
Flag Coverage Δ
unittests 87.50% <ø> (-2.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksaur
Copy link
Contributor

ksaur commented Aug 13, 2024

Hi thanks for the PR! The goal was not to remove the lines, but to update them. See this similar pr.

To push the last release, i just deleted those three lines you deleted before I pushed to pypi, and the end result is that the description is blank. We want to fix it like in the link above where the description is NOT blank. Thanks!

Copy link
Contributor

@ksaur ksaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the syntax of the description rather than just deleting it, thanks!

@LuniaKunal LuniaKunal closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants