This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Build as DLL #7
Open
Build as DLL #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows port of hiredis defines and exports a few symbols that conflict with ws2_32.lib (winsock2), leading to linker errors if both the hiredis static lib and the winsock DLL are linked in. This is also described in the open issue #5.
I order to avoid the conflicts, I added the option to build hiredis as a DLL which only exports the required API functions.
I've also added CMake build configuration to test/use my changes, although I don't have any experience with CMake so it might not be very good, and I don't know if you'd even want it.