Skip to content

Conversation

@gdams
Copy link
Member

@gdams gdams commented Jan 15, 2026

I can't find anything that confirms that there are 1ES Windows arm64 runner images so cross compiling for now

@gdams gdams force-pushed the dev/gadams/winarm64 branch from 7d5f70e to 67323f3 Compare January 15, 2026 14:21
@gdams gdams requested review from dagood and qmuntal January 15, 2026 14:22
@dagood
Copy link
Member

dagood commented Jan 15, 2026

Have you run a test internal build?

@gdams
Copy link
Member Author

gdams commented Jan 15, 2026

Have you run a test internal build?

no I haven't, I assumed it would just work as it's running on the same AMD64 VMs?

@dagood
Copy link
Member

dagood commented Jan 15, 2026

It's probably fine based on public CI, but it would be best to check that it doesn't hit problems with build manifest, signing, pdb gen.

@dagood
Copy link
Member

dagood commented Jan 15, 2026

Let's just go ahead and merge this--the change itself is a simple configuration change that should be valid, and any fallout we can treat as its own build break. (Testing in the real build is more accurate anyway!)

@dagood dagood marked this pull request as ready for review January 15, 2026 18:28
@dagood dagood requested a review from a team as a code owner January 15, 2026 18:28
@dagood dagood merged commit 13642bb into microsoft/main Jan 15, 2026
39 checks passed
@dagood dagood deleted the dev/gadams/winarm64 branch January 15, 2026 18:28
dagood pushed a commit that referenced this pull request Jan 15, 2026
dagood added a commit that referenced this pull request Jan 15, 2026
* CI: add build support for Windows arm64 (#2053)

(cherry picked from commit 13642bb)

* Ensure gopdb isn't cross-compiled (#2059)

(cherry picked from commit a21516f)

---------

Co-authored-by: George Adams <georgeadams1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants