Convert the FAST element package tests from Karma to Playwright#7268
Open
Convert the FAST element package tests from Karma to Playwright#7268
Conversation
janechu
force-pushed
the
users/janechu/convert-tests-to-playwright
branch
from
60cfb7f to
c36914e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR completes the Karma to Playwright test conversions in the
@microsoft/fast-element.🎫 Issues
Continues work on #7253
👩💻 Reviewer Notes
This is a large PR, it can't really be helped because there were so many tests. To try and mitigate the number of changes on things related to removing and re-creating tests, only tests have been converted. Follow up items are listed below to complete this issue.
In addition, though the infrastructure is still there, the Karma tests are no longer running as there are now 0 with these updates.
✅ Checklist
General
$ npm run change⏭ Next Steps
@microsoft/fast-routerKarma tests to Playwright