Open
Conversation
mohamedmansour
approved these changes
Dec 10, 2025
e092476 to
eb5d87a
Compare
eb5d87a to
f8120d2
Compare
janechu
approved these changes
Jan 22, 2026
f8120d2 to
b1625e9
Compare
b1625e9 to
bfa330d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds test coverage for a hydrating repeat directive (
f-repeat) that has no items in its initial state. This addresses a hydration scenario where empty repeats need proper hydration markers to bind correctly during client-side activation.🎫 Issues
📑 Test Plan
Added a new test case
repeat directive with no item binding should not errorthat:✅ Checklist
General
$ npm run change⏭ Next Steps
While the hydration markers documentation in
RENDERING.mdmentions this quirk, the document should describe this and other scenarios more clearly.