-
Notifications
You must be signed in to change notification settings - Fork 248
Frpt feature releases preview tracking #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5968dec
69c3557
cb96f2e
b97bf11
c0b763b
18c3890
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/fabric/gitIntegration/platformProperties/2.0.0/schema.json", | ||
| "metadata": { | ||
| "type": "Notebook", | ||
| "displayName": "Feature_Tracking_Setup", | ||
| "description": "One-time setup for feature tracking tables and views" | ||
| }, | ||
| "config": { | ||
| "version": "2.0", | ||
| "logicalId": "00000000-0000-0000-0000-000000000000" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,323 @@ | ||||||||
| { | ||||||||
| "cells": [ | ||||||||
| { | ||||||||
| "cell_type": "markdown", | ||||||||
| "id": "1a0fcaaa", | ||||||||
| "metadata": {}, | ||||||||
| "source": [ | ||||||||
| "# Feature Tracking - Setup Tables and Views\n", | ||||||||
| "\n", | ||||||||
| "**Purpose**: One-time setup for feature tracking tables and views\n", | ||||||||
| "\n", | ||||||||
| "**What this creates**:\n", | ||||||||
| "- β `feature_releases_roadmap` - Feature releases from Fabric GPS API (with roadmap)\n", | ||||||||
| "- β `preview_features_active` - Detected activated preview features\n", | ||||||||
| "- β `feature_alerts` - Alerts for new/risky preview features\n", | ||||||||
| "- β Helper SQL views for easy querying" | ||||||||
| ] | ||||||||
| }, | ||||||||
| { | ||||||||
| "cell_type": "code", | ||||||||
| "execution_count": null, | ||||||||
| "id": "c5c91aa2", | ||||||||
| "metadata": {}, | ||||||||
| "outputs": [], | ||||||||
| "source": [ | ||||||||
| "from datetime import datetime\n", | ||||||||
| "import pandas as pd" | ||||||||
|
Comment on lines
+26
to
+27
|
||||||||
| "from datetime import datetime\n", | |
| "import pandas as pd" | |
| "from datetime import datetime\n" |
Copilot
AI
Nov 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing error handling in verification code. The verification loops on lines 290-295 and 300-305 use bare except Exception as e clauses that catch all exceptions but only print them. If critical tables or views fail to create, the notebook continues without alerting the user that setup is incomplete. Consider either: 1) re-raising critical exceptions after logging, 2) maintaining a count of failures and warning at the end if any failures occurred, or 3) using a success flag that prevents subsequent steps from running if setup failed.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/fabric/gitIntegration/platformProperties/2.0.0/schema.json", | ||
| "metadata": { | ||
| "type": "Notebook", | ||
| "displayName": "Load_Feature_Tracking", | ||
| "description": "Complete feature tracking pipeline - fetch releases, detect previews, generate alerts" | ||
| }, | ||
| "config": { | ||
| "version": "2.0", | ||
| "logicalId": "00000000-0000-0000-0000-000000000000" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Missing import statement. The notebook uses
spark.sql()andspark.read.format()extensively but never imports or initializes thesparksession. While this may work in the Fabric notebook environment wheresparkis pre-initialized, it's a best practice to include a comment indicating this dependency on the pre-configured environment or to explicitly show the spark session is available.