Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Conversation

@btelnes
Copy link

@btelnes btelnes commented Apr 18, 2018

What does this PR do? Please provide some context

To prevent downgrade attacks, removing insecure transport protocols and weak ciphers. TLS 1.0 is considered insecure as it lacks support for strong ciphersuites and is known to be plagued by several known vulnerabilities.
Where should the reviewer start?

main.yml

How can this be manually tested? (brief repro steps and corpnet-URL with change)

Install STAMP then view configured protocols/ciphers by running: _**nmap --script ssl-cert,ssl-enum-ciphers -p 443 <traffic manager endpoint
What are the relevant TFS items? (list id numbers)

Bugs 108784, 108778
Definition of done:

Title of the pull request is clear and informative
Add pull request hyperlink to relevant TFS items
For large or complex change: schedule an in-person review session
This change has appropriate test coverage
Get at least two approvals

Reminders DURING merge

If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.

Configuration Pull Request
(For changes proposed to upstream)

Make sure that the following steps are done before merging

@devops team member has commented with +1
are you adding any new default values that need to be overridden when this goes live?
    Open a ticket (DEVOPS) to make sure that they have been added to secure vars.
    Add an entry to the CHANGELOG.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants