This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Security remove webserver identification #106
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please provide some context
Removes 'Server' and 'X-Powered-By' headers for improved security.
Where should the reviewer start?
playbooks/roles/nginx/tasks/main.yml
playbooks/roles/nginx/templates/etc/nginx/nginx.conf.j2
How can this be manually tested? (brief repro steps and corpnet-URL with change)
Using Postman, Fiddler, or another tool, check the response headers tpo ensure that 'Server' and 'X-Powered-By' are not present.
What are the relevant TFS items? (list id numbers)
Bugs: 103444 & 103464
Definition of done:
Reminders DURING merge
Configuration Pull Request
(For changes proposed to upstream)
Make sure that the following steps are done before merging