fix(build): add granular grype-soft-fail for PR validation#313
Merged
WilliamBerryiii merged 3 commits intomainfrom Apr 1, 2026
Merged
fix(build): add granular grype-soft-fail for PR validation#313WilliamBerryiii merged 3 commits intomainfrom
WilliamBerryiii merged 3 commits intomainfrom
Conversation
- Add grype-soft-fail input to security-scan.yml reusable workflow - Pass grype-soft-fail: true in pr-validation.yml security-scan job - Remove all resolved CVE ignore entries from .grype.yaml - Gitleaks and Secretlint remain hard-fail regardless of grype-soft-fail Closes #308 🔒 - Generated by Copilot
auyidi1
reviewed
Mar 27, 2026
katriendg
approved these changes
Mar 30, 2026
nguyena2
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a granular
grype-soft-failinput to the reusable security-scan workflow so PR validation can treat Grype vulnerability findings as warnings while keeping Gitleaks and Secretlint as hard gates. This breaks the deadlock where dependabot PRs cannot merge because Grype flags pre-existing CVEs in unrelated dependencies.The PR validation workflow now passes
grype-soft-fail: true, and.grype.yamlis cleaned of all CVE ignore entries since dependabot resolved all underlying vulnerabilities.Related Issue
Closes #308
Type of Change
Implementation Details
security-scan.yml — Added
grype-soft-failboolean input (required: false,default: false). Refactored the "Fail on Security Violations" gate step so Gitleaks and Secretlint failures always setHARD_FAILURE=true, while Grype failures respect theGRYPE_SOFT_FAILflag. The existingsoft-failinput remains as a global override.pr-validation.yml — Added
with: grype-soft-fail: trueto thesecurity-scanjob call. No other changes.main.yml — Intentionally unchanged. Grype hard-fail is retained as a post-merge safety net.
.grype.yaml — Reduced from 18 lines to 2 lines (
fail-on-severity: highonly). Removed five CVE ignore entries that dependabot has since resolved.Testing Performed
Validation Steps
security-scan.ymlYAML syntax is valid.grype-soft-faildefaults tofalse— existing callers are unaffected.pr-validation.ymlpassesgrype-soft-fail: truetosecurity-scan.main.ymldoes not passgrype-soft-fail— Grype remains a hard gate on main..grype.yamlcontains onlyfail-on-severity: high.Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codemega-linter-runner)Additional Notes
The
soft-failglobal override andgrype-soft-failscanner-specific input are complementary.soft-fail: truedisables all scanner failures;grype-soft-fail: trueonly disables Grype failures while preserving Gitleaks and Secretlint as hard gates.Screenshots (if applicable)
N/A