Skip to content

Conversation

@NirajC-Microsoft
Copy link
Contributor

Purpose

This pull request refactors the networking setup in the infrastructure Bicep files to improve modularity, clarity, and maintainability. The main change is the removal of the legacy modules/network.bicep module and the introduction of explicit, separate modules for the virtual network, Bastion Host, and Jumpbox VM. All references to networking outputs and subnet resource IDs are updated across the codebase to use the new structure. Additionally, private endpoint configurations and resource assignments have been updated to reference the new virtual network outputs, ensuring consistency and correctness.

Networking architecture refactor:

  • Removed the legacy modules/network.bicep module, including all its parameters, outputs, and subnet/NIC/NSG logic, to simplify and clarify the networking setup. (infra/modules/network.bicep)
  • Introduced explicit modules in infra/main.bicep for the virtual network (virtualNetwork), Bastion Host (bastionHost), and Jumpbox VM (jumpboxVM) with updated parameters and resource references. (infra/main.bicep)

Resource output and reference updates:

  • Updated all resource and private endpoint configurations to reference subnet and resource IDs from the new virtualNetwork module outputs instead of the removed network module. This affects modules for DNS zones, AI services, storage, CosmosDB, Key Vault, web sites, and others. (infra/main.bicep) [1] [2] [3] [4] [5] [6] [7] [8]

Private networking and endpoint improvements:

  • Added a dedicated private endpoint module for existing AI services, ensuring private DNS zone integration and correct subnet assignment when private networking is enabled. (infra/main.bicep)
  • Updated logic for AI Foundry project endpoint assignment to use a direct URL construction for existing projects, improving reliability. (infra/main.bicep)

These changes make the networking setup more modular and easier to maintain, with clearer separation of concerns and more robust resource referencing throughout the infrastructure code.

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

AjitPadhi-Microsoft and others added 20 commits September 25, 2025 16:58
… network module, enhancing structure and clarity
fix: Fixed reference num and section generation issue
fix: Optimize Network Module Deployment
fix: added dns for existing project to access
fix: added pydantic lib added with version
fix: quota unavailability for handling in quotacheck pipeline
Shreyas-Microsoft and others added 2 commits October 14, 2025 12:53
@Roopan-Microsoft Roopan-Microsoft merged commit b369fa5 into main Oct 14, 2025
14 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants