-
Notifications
You must be signed in to change notification settings - Fork 156
fix: Dev to main #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: Dev to main #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ox configurations, removing unused files
…cing modularity and clarity
… network module, enhancing structure and clarity
fix: Fixed reference num and section generation issue
fix: Optimize Network Module Deployment
fix: added dns for existing project to access
fix: added pydantic lib added with version
fix: quota unavailability for handling in quotacheck pipeline
revert: privet endpoint for existing project
Roopan-Microsoft
approved these changes
Oct 13, 2025
fix: Frontend tests
Contributor
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the networking setup in the infrastructure Bicep files to improve modularity, clarity, and maintainability. The main change is the removal of the legacy
modules/network.bicepmodule and the introduction of explicit, separate modules for the virtual network, Bastion Host, and Jumpbox VM. All references to networking outputs and subnet resource IDs are updated across the codebase to use the new structure. Additionally, private endpoint configurations and resource assignments have been updated to reference the new virtual network outputs, ensuring consistency and correctness.Networking architecture refactor:
modules/network.bicepmodule, including all its parameters, outputs, and subnet/NIC/NSG logic, to simplify and clarify the networking setup. (infra/modules/network.bicep)infra/main.bicepfor the virtual network (virtualNetwork), Bastion Host (bastionHost), and Jumpbox VM (jumpboxVM) with updated parameters and resource references. (infra/main.bicep)Resource output and reference updates:
virtualNetworkmodule outputs instead of the removednetworkmodule. This affects modules for DNS zones, AI services, storage, CosmosDB, Key Vault, web sites, and others. (infra/main.bicep) [1] [2] [3] [4] [5] [6] [7] [8]Private networking and endpoint improvements:
infra/main.bicep)infra/main.bicep)These changes make the networking setup more modular and easier to maintain, with clearer separation of concerns and more robust resource referencing throughout the infrastructure code.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information