PS: Remove environment variables from powershell/microsoft/public/sql-injection
#263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanel-y
approved these changes
Jul 24, 2025
dilanbhalla
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ction PS: Remove environment variables from `powershell/microsoft/public/sql-injection`
dilanbhalla
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ction PS: Remove environment variables from `powershell/microsoft/public/sql-injection`
dilanbhalla
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ction PS: Remove environment variables from `powershell/microsoft/public/sql-injection`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and also make the paths outputted in dataflow queries more readable.
This PR does two things (each in their own commit):
nodeIsHiddenpredicate) and which nodes to always show in a path (theneverSkipInPathGraph). We had a bug innodeIsHiddenwhich always hid uses of local variables. This meant that paths were way too compressed to be readable. Furthermore, I chose to follow C# and always show definitions in the path.The combination of these two fixes in (2) mean that paths are much more readable 🎉