Psscriptanalyzer port #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
approved these changes
Apr 22, 2025
Collaborator
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
This looks great, Chanel! 🚀 A couple of formatting comments, but otherwise I think it's perfect!
I would also be okay with moving these out of experimental, but it's probably good to at least start them off in there and then we can move them out once we're able to run PowerShell campaigns and validate the results
powershell/ql/src/experimental/UsernameOrPasswordParameter.qhelp
Outdated
Show resolved
Hide resolved
powershell/ql/src/experimental/UsernameOrPasswordParameter.qhelp
Outdated
Show resolved
Hide resolved
…codeql into psscriptanalyzer-port
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the following rules:
AvoidUsingComputerNameHardcoded
AvoidUsingConvertToSecureStringWithPlainText
AvoidUsingUsernameAndPasswordParams
ReservedCmdletChar