Add ATS pipeline parity for polyglot AppHosts#15826
Open
sebastienros wants to merge 7 commits intomainfrom
Open
Add ATS pipeline parity for polyglot AppHosts#15826sebastienros wants to merge 7 commits intomainfrom
sebastienros wants to merge 7 commits intomainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sebastienros
requested review from
JamesNK,
danegsta,
karolz-ms and
mitchdenny
as code owners
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15826Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15826" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #15708 by exposing the distributed application builder pipeline to polyglot AppHosts via standard ATS exports (rather than TypeScript-only generator special-casing), and updates the generated TypeScript surface plus polyglot fixtures to use the shared shape.
Changes:
- Export
IDistributedApplicationPipelinethrough ATS and add ATS-friendlyaddStepandconfigurecapability exports. - Update the TypeScript ATS code generator and snapshot to include the builder-level
pipelinehandle and its methods. - Update TypeScript/Python/Java polyglot AppHost fixtures to exercise the builder-level pipeline API; hide an internal manifest publishing pipeline extension from the polyglot surface.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/PolyglotAppHosts/Aspire.Hosting/TypeScript/apphost.ts | Uses the generated builder-level pipeline handle (builder.pipeline.get()) and exercises addStep/configure. |
| tests/PolyglotAppHosts/Aspire.Hosting/Python/apphost.py | Uses the generated builder-level pipeline API (builder.pipeline) and exercises add_step/configure. |
| tests/PolyglotAppHosts/Aspire.Hosting/Java/AppHost.java | Uses the generated builder-level pipeline API (builder.pipeline()) and exercises addStep/configure. |
| tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.ts | Updates the verified generated TypeScript API surface to include pipeline handle/methods. |
| src/Aspire.Hosting/Publishing/ManifestPublishingExtensions.cs | Explicitly hides internal manifest publishing pipeline extension from ATS/polyglot export surface. |
| src/Aspire.Hosting/Ats/PipelineExports.cs | Adds ATS capability exports for pipeline addStep and configure. |
| src/Aspire.Hosting/Ats/AtsTypeMappings.cs | Adds assembly-level ATS type export for IDistributedApplicationPipeline. |
| src/Aspire.Hosting.CodeGeneration.TypeScript/AtsTypeScriptCodeGenerator.cs | Adjusts method/interface generation and callback codegen (including indentation handling). |
src/Aspire.Hosting.CodeGeneration.TypeScript/AtsTypeScriptCodeGenerator.cs
Show resolved
Hide resolved
src/Aspire.Hosting.CodeGeneration.TypeScript/AtsTypeScriptCodeGenerator.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
reviewed
Apr 3, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🎬 CLI E2E Test Recordings — 56 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23968838492 |
JamesNK
reviewed
Apr 5, 2026
| List<AtsParameterInfo> requiredParams, | ||
| List<AtsParameterInfo> optionalParams) | ||
| List<AtsParameterInfo> optionalParams, | ||
| string indent = " ") |
Member
There was a problem hiding this comment.
nit: I would prefer an indent level, and then repeated the indent chars by the level.
| /// <param name="requiredBy">Optional step names that require this step.</param> | ||
| [AspireExport(Description = "Adds a pipeline step to the application")] | ||
| public static void AddStep( | ||
| this global::Aspire.Hosting.Pipelines.IDistributedApplicationPipeline pipeline, |
Member
There was a problem hiding this comment.
Why reference the type like this?
JamesNK
approved these changes
Apr 5, 2026
Member
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
Looks good — clean approach to exporting the pipeline surface through standard ATS exports. Two minor nits on pre-existing patterns in generated snapshots (Rust unused bindings, Go/Java nil guard on required callback). No blocking issues.
| pub fn configure(&self, callback: impl Fn(Vec<Value>) -> Value + Send + Sync + 'static) -> Result<(), Box<dyn std::error::Error>> { | ||
| let mut args: HashMap<String, Value> = HashMap::new(); | ||
| args.insert("pipeline".to_string(), self.handle.to_json()); | ||
| let callback_id = register_callback(callback); |
Member
There was a problem hiding this comment.
Pre-existing issue, good opportunity to fix during this work: Both add_step and configure assign let result = self.client.invoke_capability(...) but result is never used. This produces Rust unused_variable warnings. The idiomatic fix is either let _result = ... or let _ = ....
| reqArgs["callback"] = RegisterCallback(callback) | ||
| } | ||
| if dependsOn != nil { | ||
| reqArgs["dependsOn"] = SerializeValue(dependsOn) |
Member
There was a problem hiding this comment.
Pre-existing issue in the Go generator: callback is a required parameter (validated with ArgumentNullException.ThrowIfNull on the C# side), but the generated code wraps callback serialization in if callback != nil, silently omitting it from rpc args if nil is passed instead of failing. Same pattern appears in the Java addStepImpl generated code (if (callbackId != null)). Not blocking — just noting the generator emits a nil guard for a parameter that should never be nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15708 by exposing the builder pipeline through standard ATS exports instead of TypeScript-only generator special casing. This keeps the polyglot AppHost surface aligned across TypeScript, Python, and Java while preserving the existing C# pipeline API.
This change exports
IDistributedApplicationPipeline, adds ATS-friendlyaddStepandconfiguremethods on the pipeline handle, and updates the TypeScript generator snapshot plus the TypeScript, Python, and Java polyglot fixtures to use the shared generated shape. It also explicitly hides the internal manifest publishing pipeline extension from the polyglot surface. During self-review, I fixed a shared TypeScript callback-generation bug in the multi-parameterCancellationTokenpath.Dependencies required for this change: none.
Fixes #15708
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: