-
Notifications
You must be signed in to change notification settings - Fork 963
Python: ADR for create/get agent API #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces an ADR (Architecture Decision Record) that documents the misalignment between .NET and Python implementations of the create/get agent API, proposing a solution to achieve API parity.
- Documents current API differences between .NET and Python agent creation/retrieval methods
- Proposes adding missing
get_agentand enhancedcreate_agentmethods to Python implementations - Provides comprehensive comparison table of current .NET provider implementations
eavanvalkenburg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can get behind the principle, my only concern is that the overridden create agent methods will need to be async to work and that's not great
| Example: | ||
|
|
||
| ```python | ||
| from agent_framework.azure import AgentFactory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work if I want to create different types of persistent agent at the same time? We would need unique AgentFractory names, right?
|
|
||
| ## Decision Outcome | ||
|
|
||
| TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a recommendation?
This would be a good topic to discuss with Brett and Johan. Could you book a meeting with them as part 2 of the API review and review this decision.
…/agent-framework into create-agent-updates
Motivation and Context
There is a misalignment between the create/get agent API in the .NET and Python implementations. This PR contains ADR to compare APIs in both languages to decide what needs to be added.
Contribution Checklist