-
Notifications
You must be signed in to change notification settings - Fork 28
Adding Reachability project #30
base: develop
Are you sure you want to change the base?
Conversation
|
We should have a README filled out that explains the usage of this app sample. |
| // AppDelegate.h | ||
| // iOSReachability | ||
| // | ||
| // Created by Luis Meddrano-Zaldivar on 4/19/17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each app needs the standard Microsoft MIT licensing notice. Check out the other samples to grab this.
| // AppDelegate.m | ||
| // iOSReachability | ||
| // | ||
| // Created by Luis Meddrano-Zaldivar on 4/19/17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each app needs the standard Microsoft MIT licensing notice. Check out the other samples to grab this.
| // | ||
| // Created by Luis Meddrano-Zaldivar on 4/21/17. | ||
| // Copyright © 2017 Luis Meddrano-Zaldivar. All rights reserved. | ||
| // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each app needs the standard Microsoft MIT licensing notice. Check out the other samples to grab this.
|
Each header and obj-c file needs the standard Microsoft MIT licensing notice. Check out the other samples to grab this. |
| @@ -0,0 +1,64 @@ | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. How should we provide this code? I will check in with the PMs on this one.
See the overall note in the discussion.
| isa = PBXProject; | ||
| attributes = { | ||
| LastUpgradeCheck = 0830; | ||
| ORGANIZATIONNAME = "Luis Meddrano-Zaldivar"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the other samples for how to handle this.
|
Should we check in the imported VS files for this project? |
|
One difficult question here that we never answered in the early days of Islandwood; is it valid for us to provide this algorithm with Apple's plain attribution? I will consider this with Arnaud. If this PR is valid but the licensing doesn't pass muster, we may suggest a HOWTO to get reachability working in Islandwood that describes what you had to change. |
Adding Reachability project without visual studio solution.
This change is