Implement P3016R6 Resolve Inconsistencies In begin/end For valarray And Braced Initializer Lists#5847
Merged
StephanTLavavej merged 17 commits intomicrosoft:mainfrom Jan 8, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Only check that begin(initializer_list) is constexpr in C++17 onwards (tests/Dev11_1074023_constexpr). Mark libc++ std/language.support/support.initlist/support.initlist.range/begin_end.pass.cpp as known FAIL.
This comment was marked as outdated.
This comment was marked as outdated.
StephanTLavavej
changed the title
begin/end For valarray And Braced Initializer Lists
Contributor
Author
|
Hi, just FYI this PR is somewhat blocking a new test I am writing for requirements stated in [iterator.range]/1 (motivated by implementation of LWG-3987). Since it is motivated by |
`make_signed_t` requires non-bool integral/enum types, so the `static_cast` can't possibly throw.
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jan 7, 2026
Member
|
Thanks! I pushed some changes, notably to remove "strengthened" |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this C++26 feature and congratulations on getting your first-created microsoft/STL PR merged! 😹 🎉 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove free function overloads of
beginandendforinitializer_list.Replace free function overloads
emptyanddataforinitializer_listwith member functions.Replace free function overloads
beginandendforvalarraywith member functions.Provide new feature test macros
__cpp_lib_initializer_listand__cpp_lib_valarray.Resolves #5840