Contributor project automations via workflows#2584
Contributor project automations via workflows#2584StephanTLavavej merged 14 commits intomicrosoft:mainfrom celonymire:contributor-project-automation
Conversation
celonymire
left a comment
There was a problem hiding this comment.
Some of the JavaScript questions so far.
celonymire
left a comment
There was a problem hiding this comment.
New places of FIXME's.
|
While the Code Reviews project has a Work In Progress column, we deleted the "work in progress" label a few months ago as it seemed to be redundant. We can re-add it at any time, though. |
|
Sure, I'll just remove the automation to add/remove the label for now. |
|
This is officially ready for review, with everything addressed and the description updated. |
celonymire
left a comment
There was a problem hiding this comment.
One comment about the additional complexity to add logging for moving from 'Initial Review' or 'Final Review' column to 'Work in Progress' column.
strega-nil-ms
left a comment
There was a problem hiding this comment.
There're some clean ups possible
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I'll validate and push changes, one moment...
|
I pushed a conflict-free merge with Note that the In the future, it may be desirable to fuse these two actions into one YAML file. Also, if we migrate to GitHub's modern projects, this code will need to change (no plans at the moment though). |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thank you for this major workflow improvement - this will be incredibly useful for contributors! 😻 💯 🥇 |
Fixes #960
This PR adds automation for contributors to move their PR between "Work In Progress" and "Initial Review".
Previous attempt by #829 was very close, but it needed
pull_request_targetto allow fork PRs to access secrets. This technically builds upon that (even I didn't know there was a previous attempt when I implemented this).Automation So Far
/pr wipmoves the PR card to "Work In Progress". It only searches through "Initial Review" and "Final Review" for now (because the assumption right now is that PRs that got through those reviews are ready to go), can change if requested./pr reviewmoves the PR card to "Initial Review", it only searches through "Work In Progress" for the PR card.Other Automation Ideas
/pr wipDesign Comments
issues, and another workflow adding label wouldn't trigger it by default.Experimentation repository can be found here: https://github.com/sam20908/STL-PR-Workflow