Merged
Conversation
Contributor
kullJul
commented
Oct 1, 2024
kullJul
commented
- Add eslint
- Update packages
- Fix tests
- Add github workflow files
- Migrate to formatting model
add Short and Long description to en-US resources
AleksSavelev
requested changes
Oct 11, 2024
AleksSavelev
left a comment
AleksSavelev
left a comment
There was a problem hiding this comment.
Also would be perfect to migrate on the latest eslint
AleksSavelev
requested changes
Dec 2, 2024
| super.processHighContrastMode(colorPalette); | ||
|
|
||
| const isHighContrast: boolean = colorPalette.isHighContrast; | ||
| this.currentValueColor.visible = isHighContrast ? false : this.currentValueColor.visible; |
There was a problem hiding this comment.
I don't think we need this logic, since you add currentValueColor to slices and do all of this in the Base method. Did you tested if this is needed?
There was a problem hiding this comment.
Same in sparklineChartDescriptor.ts / staleDataDescriptor.ts / subtitleBaseDescriptor.ts / textFormattingDescriptor.ts
AleksSavelev
approved these changes
Dec 20, 2024
AleksSavelev
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Update dependencies and related files * Add eslint, update readme, add github workflows * Split d3 packages * Migrate to formatting model * Fix tests * Fix subtitle descriptor * add Short and Long description to en-US resources * Refactoring * Update eslint * Fix eslint errors * Remove unused dependencies * Add bold, italic and underline settings * Remove phantom js * Add displayKey for font family * Rename style prop * Move show property from the base descriptor * Added settings parsing to containers * Add high contrast mode * Fix localization keys * Fix npm vulnerabilities * Update changelog * Remove getMin getMax from axisDescriptor * Remove setFormat and getFormat * Fix tests * Remove redundant hcm logic * Fix lint error --------- Co-authored-by: Alexey <v-alesemenov@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.