Skip to content

Checking for Activate Script inside bin of venv for Activation #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathambande merged 2 commits into from
Jan 28, 2026
Merged

Checking for Activate Script inside bin of venv for Activation #2805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924d864
Checking activate script inside venv before activation
Jan 28, 2026
d370848
using virtualenv dir instead of hard slash
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/startupscriptgenerator/src/python/scriptgenerator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ func (gen *PythonStartupScriptGenerator) getPackageSetupCommand() string {
scriptBuilder.WriteString(" echo WARNING: Could not find virtual environment directory '" + virtualEnvDir + "'.\n")
}
} else {
scriptBuilder.WriteString(fmt.Sprintf("echo '. /%s/bin/activate' >> ~/.bashrc\n", virtualEnvironmentName))
compressedFile := gen.Manifest.CompressedVirtualEnvFile
virtualEnvDir := "/" + virtualEnvironmentName
scriptBuilder.WriteString(fmt.Sprintf("echo 'if [ -f %s/bin/activate ]; then . %s/bin/activate; fi' >> ~/.bashrc\n", virtualEnvDir, virtualEnvDir))
compressedFile := gen.Manifest.CompressedVirtualEnvFile
if strings.HasSuffix(compressedFile, ".zip") {
scriptBuilder.WriteString("echo Found virtual environment .zip archive.\n")
scriptBuilder.WriteString(
Expand Down Expand Up @@ -290,7 +290,7 @@ func (gen *PythonStartupScriptGenerator) getVenvHandlingScript(virtualEnvName st
scriptBuilder.WriteString(fmt.Sprintf(". %s/bin/activate\n", virtualEnvName))
}
} else {
scriptBuilder.WriteString(fmt.Sprintf(". /%s/bin/activate\n", virtualEnvName))
scriptBuilder.WriteString(fmt.Sprintf("if [ -f %s/bin/activate ]; then . %s/bin/activate; fi\n", virtualEnvDir, virtualEnvDir))
}
}

Expand Down
Loading