fix: wrap extension parser calls in try-catch to ensure correct error pointers #2660
+115
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pointers
When extension parsers throw OpenApiException, the exceptions are now caught in LoadExtension methods across all OpenAPI versions (V2, V3, V3.1, V3.2). This ensures the error pointer correctly includes all path segments (e.g., #/definitions/demo/x-tag instead of #/definitions/x-tag).
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
refactor: make V2 LoadExtension consistent with other versions
Moved the return statement for JsonNodeExtension outside the catch block to match the pattern used in V3, V31, and V32 deserializers.
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
style: use raw string literals for JSON test data
Changed from verbatim string literals (@"...") to raw string literals ("""...""") for consistency with existing test code.
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
chore: refactors test definition for better coverage
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
chore: removes extraneous version
|
adrian05-ms
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflection of #2659