Skip to content

Conversation

@MaxDac
Copy link
Contributor

@MaxDac MaxDac commented Dec 2, 2025

This pull request updates the supported .NET versions to include .NET 10, resolving the conflicts in compilation and unit testing, keeping the older framework support unchanged.

In the following, the implementation details:

  • Missing packages were added in the reference group which targets the older framework.
  • Added precise namespace to identify the method currently used in the HostBuilderExtensions class.
  • Made reference to System.Linq.Async package conditional to every framework except .NET 10: this condition does not make use of the alias defined in the Directory.Build.props as it is a specific issue related to .NET 10 where the method used from the package has been included in the Framework itself.

Copilot AI review requested due to automatic review settings December 2, 2025 15:50
@MaxDac MaxDac requested a review from a team as a code owner December 2, 2025 15:50
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 4
Test Code 14
Subtotal 18
Ignored Code 41
Total 59

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Added .NET 10 double targeting XS⚠️ ◾ Added .NET 10 double targeting Dec 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds .NET 10 as a target framework alongside the existing .NET 9 support, enabling multi-targeting compilation and testing. The changes address framework-specific compatibility issues including namespace conflicts and built-in functionality that replaces external packages in .NET 10.

  • Updates the latest supported .NET version from 9.0 to 10.0 in build configuration
  • Adds package references for older framework support (Microsoft.FeatureManagement and System.Linq.Async)
  • Works around namespace conflicts by using fully qualified names where .NET 10 introduces conflicting types
  • Conditionally excludes System.Linq.Async package for .NET 10 since the functionality is now built into the framework

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
Directory.Build.props Updates LatestSupportedDotNetVersion property from net9.0 to net10.0 to enable .NET 10 targeting
Directory.Packages.props Adds Microsoft.FeatureManagement and System.Linq.Async package versions to the "Previous DotNet Package Versions" section for .NET 9 compatibility
src/Hosting.Services.Web/HostBuilderExtensions.cs Fully qualifies Validation.ThrowIfNullOrWhiteSpace calls to resolve namespace conflict introduced in .NET 10
tests/FeatureManagement.UnitTests/Microsoft.Omex.Extensions.FeatureManagement.UnitTests.csproj Adds conditional exclusion of System.Linq.Async package for net10.0 since the functionality is built into the framework

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Member

@K-Cully K-Cully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package references need to be fixed.
The current change reverts all 9.x builds to use 8.x dependencies.

@MaxDac MaxDac requested a review from K-Cully December 2, 2025 16:28
@github-actions github-actions bot changed the title XS⚠️ ◾ Added .NET 10 double targeting XS✔ ◾ Added .NET 10 double targeting Dec 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

@K-Cully K-Cully changed the title XS✔ ◾ Added .NET 10 double targeting XS✔ ◾ Added .NET 10 dual targeting Dec 3, 2025
@MaxDac MaxDac requested a review from K-Cully December 3, 2025 14:08
@MaxDac MaxDac merged commit 5edcb41 into main Dec 3, 2025
7 of 8 checks passed
@MaxDac MaxDac deleted the maxdac/feature/adding-net-10-double-target branch December 3, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants