-
Notifications
You must be signed in to change notification settings - Fork 16
Add Public Key #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amao9098
wants to merge
14
commits into
microsoft:master
Choose a base branch
from
amao9098:container
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Public Key #59
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ecd64e5
add more connections
8034ee1
add container
467eadb
add fragmentation config
beeed0f
merge
6138737
add tcp to frag
20b5e85
merge
e7c1426
remove validate on config name
b1dd067
Merge remote-tracking branch 'upstream/master' into container
ba73dc2
remove tcp
f88bae7
adding key even if file exists
d2192b5
add new line
5dcbf71
add to check passkey
d534235
edit str
fd7622b
reduce iterations and add udp/tcp profiles
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,16 +118,11 @@ param( | |
| Write-Host "`nSSHD default config files already exist" | ||
| } | ||
|
|
||
| if (-NOT (Test-Path "$env:ProgramData\ssh\administrators_authorized_keys")) | ||
| { | ||
| if ($null -eq (Select-String -Path "$env:ProgramData\ssh\administrators_authorized_keys" -Pattern $authorizedKey)) { | ||
| Write-Host "`nAdd the AuthorizedKey as a trusted admin key" | ||
| Add-Content -Force -Path "$env:ProgramData\ssh\administrators_authorized_keys" -Value "$authorizedKey" | ||
| Add-Content -Force -Path "$env:ProgramData\ssh\administrators_authorized_keys" -Value "`n$authorizedKey" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you need the `n? I think Add-Content will add a new line by default.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like the `n is still here. |
||
| icacls.exe "$env:ProgramData\ssh\administrators_authorized_keys" /inheritance:r /grant "Administrators:F" /grant "SYSTEM:F" | ||
| } | ||
| else | ||
| { | ||
| Write-Host "`nTrusted admin keys already exist" | ||
| } | ||
|
|
||
| if (-NOT (Test-Path "$env:ProgramFiles\PowerShell\7\")) | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this prevents adding new configs for one off tests.