fix: support nested tags in structured compression regex (#201)#243
Open
ousamabenyounes wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: support nested tags in structured compression regex (#201)#243ousamabenyounes wants to merge 1 commit intomicrosoft:mainfrom
ousamabenyounes wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The content group used [^<]+ which fails when a <llmlingua> block contains inner HTML/XML tags (e.g. <tag>...</tag>), silently dropping all subsequent segments. Replaced with a non-greedy alternation that skips over inner tags while still terminating at </llmlingua>. Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
|
@ousamabenyounes please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #201
The regex pattern used in
segment_structured_contextto parse<llmlingua>…</llmlingua>blocks used[^<]+for the content group. When a block contained an inner HTML/XML tag (e.g.<tag>nested</tag>), the<from the inner tag terminated the match early, silently dropping that segment and all subsequent ones.Before (broken):
After (fixed):
The new alternation
(?:[^<]*(?:<(?!/llmlingua>)[^>]*>)?)*?reads:<characters, then optionally an inner tag that is not</llmlingua></llmlingua>Before submitting
Issue: [Bug]: regex pattern does not handle nested tags in prompt (structured compression) #201
Added
tests/test_nested_tag_regex.pywith 4 unit tests: plain content regression, nested-tag fix, full multi-segment scenario, and rate-attribute preservation. Tests read the pattern directly from source to stay in sync with the code.Who can review?
@iofu728 @QianhuiWu
Generated by Claude Code
Vibe coded by ousamabenyounes