-
Notifications
You must be signed in to change notification settings - Fork 233
Add SDK/version as User-Agent in HTTPClients #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format and modify tests accordingly
Capitalize AssemblyVersion, use cs instead of C#
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds dynamic SDK version information to User-Agent headers across all language SDKs (Rust, C#, Python, JavaScript) to improve telemetry and debugging capabilities.
- Extract version information programmatically instead of hardcoding values
- Update HTTP clients to include SDK name and version in User-Agent headers
- Bump package versions to reflect the changes
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/rust/src/client.rs | Uses Cargo environment variable to get package version for User-Agent |
| sdk/cs/src/FoundryLocalManager.cs | Adds assembly version extraction and User-Agent header configuration |
| sdk/python/foundry_local/client.py | Updates HTTP client to include SDK version in User-Agent header |
| sdk/python/foundry_local/version.py | New version file containing SDK version string |
| sdk/js/src/client.ts | Adds User-Agent header with SDK version to HTTP requests |
| sdk/js/src/version.ts | Generated version file for JavaScript SDK |
Files not reviewed (1)
- sdk/js/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
amarin16
reviewed
Jul 29, 2025
amarin16
reviewed
Jul 29, 2025
amarin16
reviewed
Jul 29, 2025
amarin16
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The changes update the HTTP client implementations in Rust, C#, Python, and JavaScript to dynamically include the SDK version in the User-Agent header. This ensures consistent version reporting while also bumping the overall package versions.