Fixup workflow so it runs cargo fmts in the sub directories. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 27, 2025 17:43
snnn
reviewed
May 29, 2025
| - 'sdk/rust/**' | ||
| - 'samples/rust/**' | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Add your branch name?
Or, you must resolve the conflicts first. Now your PR has conflicts:
This branch has conflicts that must be resolved
So no PR pipeline can run.
jonwis
reviewed
May 29, 2025
.github/workflows/rustfmt.yml
Outdated
| working-directory: sdk/rust | ||
| run: cargo fmt --all -- --check | ||
| - name: Check Samples | ||
| working-directory: samples |
Author
|
Found a fmt issue, so it's working! Will fix the issues and push an update. |
samuel100
approved these changes
May 29, 2025
added 2 commits
May 29, 2025 14:23
…microsoft/Foundry-Local into user/chendrixson/rust-workflows
Author
|
Everything looking good with the workflow, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chose to add a cargo.toml file in the samples directory and cargo fmt in both places rather than having a top level cargo.toml workspace file. Better to keep the root cleaner.