Skip to content

Bad API report change#24504

Closed
CraigMacomber wants to merge 3 commits intomicrosoft:mainfrom
CraigMacomber:BadAPIReport
Closed

Bad API report change#24504
CraigMacomber wants to merge 3 commits intomicrosoft:mainfrom
CraigMacomber:BadAPIReport

Conversation

@CraigMacomber
Copy link
Contributor

Description

This should fail on CI

Reviewer Guidance

Test PR, no review desired.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree public api change Changes to a public API base: main PRs targeted against main branch labels May 1, 2025
@alexvy86
Copy link
Contributor

alexvy86 commented May 9, 2025

Kicked off a new pipeline run with "Enable system diagnostics" to see if the additional logs tell us anything interesting. Original run is here.

@alexvy86
Copy link
Contributor

It was a regression in api-extractor 7.52.5, fixed in 7.52.8. Should be fixed in our repo by #24599.

@github-actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  232440 links
    1714 destination URLs
    1946 URLs ignored
       0 warnings
       0 errors


@CraigMacomber
Copy link
Contributor Author

Fix confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants