Skip to content

Address feedback on test filesystem setup and comments #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arrayka merged 5 commits into from
Jan 23, 2026
Merged

Address feedback on test filesystem setup and comments #701

arrayka merged 5 commits into from
Jan 23, 2026

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026 •
edited
Loading

  • Revert comment at line 1430 in pq_construction.rs to original text
  • Revert comment at line 1681 in pq_construction.rs to original text
  • Revert comment at line 1787 in pq_construction.rs to original text
  • Revert test_index_path() to return String with virtual path
  • Remove .to_string_lossy() from setup_reader()
  • Keep both test_index_path() and test_index_os_path() functions for separate use cases
  • Run tests to validate changes

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 23, 2026
Open
@arrayka
Address PR feedback: revert comments and refactor test helper functions
dcc9067 
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Copilot AI changed the title [WIP] Update unit tests to enforce no real filesystem writes Address feedback on test filesystem setup and comments Jan 23, 2026
Copilot AI requested a review from arrayka January 23, 2026 09:18
arrayka
arrayka requested changes Jan 23, 2026
View reviewed changes
@arrayka
Revert test_index_path() to return String and remove .to_string_lossy()
27ad31f 
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Copilot AI requested a review from arrayka January 23, 2026 09:29
@arrayka
Remove test_index_os_path() and use test_index_path() instead
90934ad 
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
Copilot stopped work on behalf of arrayka due to an error January 23, 2026 09:38
The session was cancelled by the user.
@arrayka
Revert commit 90934ad
26697ce 
Co-authored-by: arrayka <1551741+arrayka@users.noreply.github.com>
@arrayka arrayka marked this pull request as ready for review January 23, 2026 09:49
@arrayka arrayka merged commit e764dc8 into u/arrayka/remove_physicalfs_from_tests Jan 23, 2026
1 check passed
@arrayka arrayka deleted the copilot/sub-pr-700 branch January 23, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arrayka arrayka arrayka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arrayka arrayka

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arrayka