Skip to content

Fixing flaky test_compute_relative_contrast_with_random_data #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arrayka wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

Fixing flaky test_compute_relative_contrast_with_random_data #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions diskann-tools/src/bin/subsample_bin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use rand_distr::{Distribution, StandardUniform};
use diskann::utils::VectorRepr;
use diskann_providers::storage::FileStorageProvider;
use diskann_providers::storage::StorageWriteProvider;
use diskann_providers::utils::{write_metadata, SampleVectorReader, SamplingDensity};
use diskann_providers::utils::{random, write_metadata, SampleVectorReader, SamplingDensity};
use diskann_tools::utils::DataType;

/// Subsamples vectors from a DiskANN style binary file.
Expand Down Expand Up @@ -43,7 +43,7 @@ fn create_rng(seed: Option<u64>) -> StdRng {
match seed {
Some(seed) => StdRng::seed_from_u64(seed),
None => {
let mut system_rng = rand::rng();
let mut system_rng = random::create_rnd();
StdRng::from_rng(&mut system_rng)
}
}
Expand Down
7 changes: 4 additions & 3 deletions diskann-tools/src/utils/relative_contrast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

use diskann::{utils::VectorRepr, ANNError};
use diskann_providers::storage::StorageReadProvider;
use diskann_providers::utils::random;
use diskann_providers::{model::graph::traits::GraphDataType, utils::file_util::load_bin};
use rand::Rng;

Expand Down Expand Up @@ -33,7 +34,7 @@ fn average_squared_distance<Data: GraphDataType>(
base: &[Vec<Data::VectorDataType>],
num_random_samples: usize,
) -> CMDResult<f32> {
let mut rng = rand::rng();
let mut rng = random::create_rnd();
let n = base.len();
let mut sum_dist = 0.0;
for _ in 0..num_random_samples {
Expand Down Expand Up @@ -125,7 +126,7 @@ mod relative_contrast_tests {
// Generate 1000 random vectors of fp16 data type with 384 dimensions
let num_vectors = 1000;
let dim = 384;
let mut rng = rand::rng();
let mut rng = random::create_rnd_in_tests();
let base: Vec<f16> = (0..num_vectors * dim)
.map(|_| f16::from_f32(rng.random_range(0.0..1.0)))
.collect();
Expand Down Expand Up @@ -213,7 +214,7 @@ mod relative_contrast_tests {

let num_queries = 10;
let dim = 128;
let mut rng = rand::rng();
let mut rng = random::create_rnd_in_tests();
let query: Vec<f16> = (0..num_queries * dim)
.map(|_| f16::from_f32(rng.random_range(0.0..1.0)))
.collect();
Expand Down