Explicitly specify the paths for onnx models #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dnsmos_local.py By explicitly specifying paths, it is easier to run dnsmos_local.py from other directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of dnsmos_local.py assumes the script is called from the same directory as dnsmos_local.py. Therefore, you need to move to the "DNSMOS" directory when you execute the script.
My implementation
I added one line of code to get the absolute path of the "DNSMOS" directory where dnsmos_local.py resides. By specifying the onnx models relative to this path, the paths of the onnx models can be always resolved regardless of where dnsmos_local.py is called from. This makes using the script a lot more easier.