This repository was archived by the owner on Nov 16, 2023. It is now read-only.
feat: remove prebuilt entity types options#1269
Open
mattmazzola wants to merge 4 commits intomasterfrom
Open
Conversation
Author
|
After more investigation, we had to leave the extra EntityTypes when editing Entity for existing bots which used direct prebuilts. Perhaps we can remove them in few months after people migrate. Also, was looking at cleaning up server also but the prebuilts that are implicitly created as a result of creating entity with resolver also exist at the top level so they still need the EntityTypes defined there. |
LarsLiden
reviewed
Sep 3, 2019
Member
LarsLiden
left a comment
LarsLiden
left a comment
There was a problem hiding this comment.
Can we discuss this at the design review meeting. I seem to remember that someone (Shahin?) thought there was a use case where folks might still need this.
mattmazzola
added
FYI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only removes from dropdown for now. Will need to work on server after. There was a lot of complexity with overloading the entity type to be custom string and relying on prebuilt prefix stuff. Perhaps we can remove a lot of logic there.
I assume we'll have to leave it in for a while but the
CLM.isPrebuiltfunction is now obsolete since there can't be prebuilts, only entities with resolver.Before:
After:
Fixes ADO#2232 (Partially)