-
Notifications
You must be signed in to change notification settings - Fork 42
feat(terraform): set base_name as optional parameter #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(terraform): set base_name as optional parameter #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request parameterizes the base_name value across four Azure AI Foundry reference architectures, converting hardcoded local values into configurable Terraform variables. This enhancement allows users to customize the naming suffix for their resources while maintaining backward compatibility through sensible defaults.
Changes:
- Added
base_namevariable to all four reference architectures (foundry_basic, foundry_basic_private, foundry_standard, foundry_standard_private) - Replaced hardcoded
base_namelocal values with variable references - Maintained backward compatibility by using previous hardcoded values as defaults
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| reference_architectures/foundry_basic/variables.tf | Added base_name variable with default value "basic" |
| reference_architectures/foundry_basic/main.tf | Updated local value to reference new variable instead of hardcoded string |
| reference_architectures/foundry_basic_private/variables.tf | Added base_name variable with default value "basic-private" |
| reference_architectures/foundry_basic_private/main.tf | Updated local value to reference new variable instead of hardcoded string |
| reference_architectures/foundry_standard/variables.tf | Added base_name variable with default value "standard" |
| reference_architectures/foundry_standard/main.tf | Updated local value to reference new variable instead of hardcoded string |
| reference_architectures/foundry_standard_private/variables.tf | Added base_name variable with default value "standard-private" |
| reference_architectures/foundry_standard_private/main.tf | Updated local value to reference new variable instead of hardcoded string |
|
@timmyreilly, thanks for the contribution! Can you run |
π₯ Pull Request
π Related Issue(s)
Close #352
β What are you trying to address
Allow base_name to be set as a variable
β¨ Description of new changes
pass base_name to be used as part of the unique suffix with a default as standard.
βοΈ Checklist