Skip to content

Conversation

@timmyreilly
Copy link

@timmyreilly timmyreilly commented Jan 13, 2026

πŸ“₯ Pull Request

πŸ”— Related Issue(s)

Close #352

❓ What are you trying to address

Allow base_name to be set as a variable

✨ Description of new changes

pass base_name to be used as part of the unique suffix with a default as standard.

β˜‘οΈ Checklist

  • πŸ” I have performed a self-review of my own code.
  • πŸ“ I have commented my code, particularly in hard-to-understand areas.
  • 🧹 I have run the linter and fixed any issues (if applicable).
  • πŸ“„ I have updated the documentation to reflect my changes (if necessary).

@timmyreilly timmyreilly requested a review from a team as a code owner January 13, 2026 03:23
Copilot AI review requested due to automatic review settings January 13, 2026 03:23
@timmyreilly timmyreilly changed the title Codespace miniature space invention p5xpxj7qg7h9w6q Set base_name as optional parameter Jan 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request parameterizes the base_name value across four Azure AI Foundry reference architectures, converting hardcoded local values into configurable Terraform variables. This enhancement allows users to customize the naming suffix for their resources while maintaining backward compatibility through sensible defaults.

Changes:

  • Added base_name variable to all four reference architectures (foundry_basic, foundry_basic_private, foundry_standard, foundry_standard_private)
  • Replaced hardcoded base_name local values with variable references
  • Maintained backward compatibility by using previous hardcoded values as defaults

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
reference_architectures/foundry_basic/variables.tf Added base_name variable with default value "basic"
reference_architectures/foundry_basic/main.tf Updated local value to reference new variable instead of hardcoded string
reference_architectures/foundry_basic_private/variables.tf Added base_name variable with default value "basic-private"
reference_architectures/foundry_basic_private/main.tf Updated local value to reference new variable instead of hardcoded string
reference_architectures/foundry_standard/variables.tf Added base_name variable with default value "standard"
reference_architectures/foundry_standard/main.tf Updated local value to reference new variable instead of hardcoded string
reference_architectures/foundry_standard_private/variables.tf Added base_name variable with default value "standard-private"
reference_architectures/foundry_standard_private/main.tf Updated local value to reference new variable instead of hardcoded string

@PabloZaiden PabloZaiden changed the title Set base_name as optional parameter feat(terraform): set base_name as optional parameter Jan 13, 2026
@PabloZaiden
Copy link
Collaborator

@timmyreilly, thanks for the contribution!

Can you run task docs to regenerate the docs based on the updated terraform code, commit the changes, and task lint to validate that there are no linting issue?
Once that passes, I’ll merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set base_name as a variable for suffix customaization

2 participants