Validate storage account name in Register TRE Bundle #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation into the "Check required values" stage of the "Register TRE Bundle" workflow to provide early warning if the chosen storage account name doesn't conform to the format that Azure allows.
Member
|
@jamesridgway thanks, is this the right workflow for this? I think https://github.com/microsoft/AzureTRE-Deployment/blob/main/.github/workflows/deploy_tre_reusable.yml runs first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement
What is being addressed
Allow CI workflows to fail early via the "Register TRE Bundle" workflow is the Azure storage account name does not conform to the conventions that Azure expects
How is this addressed
Add validation into the "Check required values" stage of the "Register TRE Bundle" workflow to provide early warning if the chosen storage account name doesn't conform to the format that Azure allows.