Agent Framework SDK by mrunalhirve128 · Pull Request #5 · microsoft/Agent365-python

mrunalhirve128 · 2025-10-29T22:07:11Z

Added tooling sdk for Agents Framework

Limitation with Microsoft.Extensions.AI Framework Architecture
The Microsoft.Extensions.AI framework (which likely underlies the agent infrastructure) follows an immutable configuration pattern where:
• Tool definitions are part of the agent's core configuration
• The agent's execution context is optimized around a fixed set of tools
• Runtime tool modification would require rebuilding the entire agent context
Hence there is no way to update the agent with new tools

Package Update
microsoft-agents-a365-observability-core[jaeger] depends on opentelemetry-exporter-jaeger >= 1.20.0
microsoft-agents-a365-tooling-extensions-agentframework[dev] depends on agent-framework-azure-ai >= 0.1.0 which in turn depends on agent-framework-core
agent-framework-core depends on opentelemetry-exporter-otlp-proto-grpc >= 1.36.0
There's a conflict with the protobuf and googleapis-common-protos versions between these OpenTelemetry packages

Copilot

Pull Request Overview

This pull request refactors MCP tool registration services across multiple frameworks to simplify initialization and improve logging consistency. It also adds a new Agent Framework extension library with comprehensive tooling support.

Simplified constructor patterns by removing optional dependency injection parameters
Added consistent logging throughout MCP tool registration workflows
Created new Agent Framework extension package with MCP tool registration capabilities

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
mcp_tool_registration_service.py (semantickernel)	Removed optional constructor parameters, now directly instantiates McpToolServerConfigurationService and removed null check
mcp_tool_registration_service.py (openai)	Added copyright header, logger support, and comprehensive logging statements throughout tool registration workflow
setup.py (agentframework)	New setup file with dynamic versioning based on UTC timestamp
pyproject.toml (agentframework)	New project configuration for Agent Framework extension package
mcp_tool_registration_service.py (agentframework)	New implementation of MCP tool registration service for Agent Framework with full logging support
init.py (agentframework/services)	New module initialization exporting McpToolRegistrationService
init.py (agentframework)	New package initialization with comprehensive module documentation
README.md (agentframework)	New comprehensive documentation for the Agent Framework extension library

...xtensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/__init__.py

...ions-openai/microsoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

libraries/microsoft-agents-a365-tooling-extensions-agentframework/pyproject.toml

…/github.com/microsoft/Agent365-python into users/mrunalhirve/AgentFrameworkSDKInPython

libraries/microsoft-agents-a365-tooling-extensions-agentframework/setup.py

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

libraries/microsoft-agents-a365-tooling-extensions-agentframework/setup.py

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

...ions-openai/microsoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py

…osoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py

...-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/__init__.py

...xtensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/__init__.py

…/github.com/microsoft/Agent365-python into users/mrunalhirve/AgentFrameworkSDKInPython

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

libraries/microsoft-agents-a365-tooling-extensions-agentframework/pyproject.toml

…ork/pyproject.toml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md

…ork/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md

…/github.com/microsoft/Agent365-python into users/mrunalhirve/AgentFrameworkSDKInPython

Copilot

Pull Request Overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.

… asserts, and more - Fix #1: Downgrade sensitive data logging from INFO to DEBUG in agent365_exporter.py - Fix #2: Fix unpaired context.attach() in opentelemetry_scope.py add_baggage() by storing and detaching baggage tokens on scope end - Fix #3: Add bounded OrderedDict caps to unbounded dicts in OpenAI trace_processor.py - Fix #4: Replace 30 assert statements with proper TypeError raises in LangChain utils.py - Fix #5: Log security warning when HTTP domain override is detected - Fix #6: Warn when bearer token sent over non-HTTPS connection - Fix #10: Respect Retry-After header and use exponential backoff in retries - Fix #13: Rename reset() to _reset() in ObservabilityHostingManager - Fix #15: Replace print() with logger.warning() in LangChain tracer_instrumentor.py Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Initial plan * Replace assert statements with explicit TypeError raises in langchain utils Replace all 30 assert statements in utils.py with equivalent if-not-raise TypeError checks. This ensures type validation is not silently stripped when Python runs with -O (optimized mode). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * security: fix sensitive data logging, context leak, unbounded memory, asserts, and more - Fix #1: Downgrade sensitive data logging from INFO to DEBUG in agent365_exporter.py - Fix #2: Fix unpaired context.attach() in opentelemetry_scope.py add_baggage() by storing and detaching baggage tokens on scope end - Fix #3: Add bounded OrderedDict caps to unbounded dicts in OpenAI trace_processor.py - Fix #4: Replace 30 assert statements with proper TypeError raises in LangChain utils.py - Fix #5: Log security warning when HTTP domain override is detected - Fix #6: Warn when bearer token sent over non-HTTPS connection - Fix #10: Respect Retry-After header and use exponential backoff in retries - Fix #13: Rename reset() to _reset() in ObservabilityHostingManager - Fix #15: Replace print() with logger.warning() in LangChain tracer_instrumentor.py Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Restore agent/tenant IDs and response text in exporter log messages Agent IDs and tenant IDs are not sensitive data and are useful for debugging. Restore them in debug/error log messages. Also restore truncated response text in HTTP error logs to help developers debug failures. Log levels remain at DEBUG (from the prior security fix). Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Remove add_baggage() from OpenTelemetryScope The method had an unpaired context.attach() that leaked context tokens. Users should use BaggageBuilder.build() context manager instead, which properly restores the previous context on exit. Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Security hardening for observability packages Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Fix formatting in test_agent365_exporter.py and replace remaining raise TypeError with isinstance guards in langchain utils.py Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Move _parse_retry_after to exporters/utils.py as standalone parse_retry_after function Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Replace type(e).__name__ with str(e) in exporter error logging per PR review Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * feat: add bounded collections for LangChain tracer and OutputScope - Convert LangChain _spans_by_run from unbounded DictWithLock to bounded OrderedDict with _MAX_TRACKED_RUNS=10000 cap - Add _cap_ordered_dict helper for FIFO eviction (matching OpenAI pattern) - Add thread-safe lock usage for _spans_by_run in error handlers - Add _MAX_OUTPUT_MESSAGES=5000 cap for OutputScope._output_messages - Add unit tests for both bounded collections Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> Co-authored-by: Nikhil Navakiran <nikhil.navakiran@gmail.com>

* Initial plan * Replace assert statements with explicit TypeError raises in langchain utils Replace all 30 assert statements in utils.py with equivalent if-not-raise TypeError checks. This ensures type validation is not silently stripped when Python runs with -O (optimized mode). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * security: fix sensitive data logging, context leak, unbounded memory, asserts, and more - Fix microsoft#1: Downgrade sensitive data logging from INFO to DEBUG in agent365_exporter.py - Fix microsoft#2: Fix unpaired context.attach() in opentelemetry_scope.py add_baggage() by storing and detaching baggage tokens on scope end - Fix microsoft#3: Add bounded OrderedDict caps to unbounded dicts in OpenAI trace_processor.py - Fix microsoft#4: Replace 30 assert statements with proper TypeError raises in LangChain utils.py - Fix microsoft#5: Log security warning when HTTP domain override is detected - Fix microsoft#6: Warn when bearer token sent over non-HTTPS connection - Fix microsoft#10: Respect Retry-After header and use exponential backoff in retries - Fix microsoft#13: Rename reset() to _reset() in ObservabilityHostingManager - Fix microsoft#15: Replace print() with logger.warning() in LangChain tracer_instrumentor.py Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Restore agent/tenant IDs and response text in exporter log messages Agent IDs and tenant IDs are not sensitive data and are useful for debugging. Restore them in debug/error log messages. Also restore truncated response text in HTTP error logs to help developers debug failures. Log levels remain at DEBUG (from the prior security fix). Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Remove add_baggage() from OpenTelemetryScope The method had an unpaired context.attach() that leaked context tokens. Users should use BaggageBuilder.build() context manager instead, which properly restores the previous context on exit. Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Security hardening for observability packages Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Fix formatting in test_agent365_exporter.py and replace remaining raise TypeError with isinstance guards in langchain utils.py Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Move _parse_retry_after to exporters/utils.py as standalone parse_retry_after function Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Replace type(e).__name__ with str(e) in exporter error logging per PR review Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * feat: add bounded collections for LangChain tracer and OutputScope - Convert LangChain _spans_by_run from unbounded DictWithLock to bounded OrderedDict with _MAX_TRACKED_RUNS=10000 cap - Add _cap_ordered_dict helper for FIFO eviction (matching OpenAI pattern) - Add thread-safe lock usage for _spans_by_run in error handlers - Add _MAX_OUTPUT_MESSAGES=5000 cap for OutputScope._output_messages - Add unit tests for both bounded collections Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> Co-authored-by: Nikhil Navakiran <nikhil.navakiran@gmail.com>

mrunalhirve128 added 6 commits October 29, 2025 15:06

Agent framework

cb94bc3

ruff format

f12a244

update tooling service

19917d7

fixed logger in open ai

0082a80

Fix init for sk

1289d10

fix

c82e08b

mrunalhirve128 marked this pull request as ready for review October 31, 2025 01:58

mrunalhirve128 requested a review from rahuldevikar761 as a code owner October 31, 2025 01:58

Copilot AI review requested due to automatic review settings October 31, 2025 01:58

mrunalhirve128 requested review from juliomenendez, nikhilNava and pontemonti as code owners October 31, 2025 01:58

Copilot AI reviewed Oct 31, 2025

View reviewed changes

...xtensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/__init__.py Show resolved Hide resolved

...ions-openai/microsoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py Outdated Show resolved Hide resolved

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py Outdated Show resolved Hide resolved

Apply suggestion from @Copilot

c734e46

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 31, 2025 02:36

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py Outdated Show resolved Hide resolved

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py Show resolved Hide resolved

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py Show resolved Hide resolved

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py Outdated Show resolved Hide resolved

Copilot AI reviewed Oct 31, 2025

View reviewed changes

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-agentframework/pyproject.toml Show resolved Hide resolved

mrunalhirve128 added 2 commits October 30, 2025 19:40

push main toml

609d4d7

Merge branch 'users/mrunalhirve/AgentFrameworkSDKInPython' of https:/…

34a668b

…/github.com/microsoft/Agent365-python into users/mrunalhirve/AgentFrameworkSDKInPython

rahuldevikar761 reviewed Oct 31, 2025

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-agentframework/setup.py Show resolved Hide resolved

resolve comments

10b220d

Copilot AI review requested due to automatic review settings October 31, 2025 03:01

Copilot AI reviewed Oct 31, 2025

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-agentframework/setup.py Show resolved Hide resolved

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md Outdated Show resolved Hide resolved

mrunalhirve128 added 2 commits October 30, 2025 20:04

fix

b8badbd

fix

bb11f43

Copilot AI reviewed Oct 31, 2025

View reviewed changes

...ions-openai/microsoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py Outdated Show resolved Hide resolved

Update libraries/microsoft-agents-a365-tooling-extensions-openai/micr…

313c904

…osoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 31, 2025 03:21

Copilot AI reviewed Oct 31, 2025

View reviewed changes

mrunalhirve128 added 3 commits October 30, 2025 20:28

test

320d67a

Merge branch 'users/mrunalhirve/AgentFrameworkSDKInPython' of https:/…

9f16dee

…/github.com/microsoft/Agent365-python into users/mrunalhirve/AgentFrameworkSDKInPython

Pr comment

5cb7e41

Copilot AI review requested due to automatic review settings October 31, 2025 03:37

Copilot AI reviewed Oct 31, 2025

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-agentframework/pyproject.toml Outdated Show resolved Hide resolved

Update libraries/microsoft-agents-a365-tooling-extensions-agentframew…

0f97ac2

…ork/pyproject.toml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 31, 2025 03:41

Copilot AI reviewed Oct 31, 2025

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md Outdated Show resolved Hide resolved

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md Outdated Show resolved Hide resolved

Update libraries/microsoft-agents-a365-tooling-extensions-agentframew…

bdc99f0

…ork/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings October 31, 2025 04:02

Update libraries/microsoft-agents-a365-tooling-extensions-agentframew…

4338e58

…ork/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Oct 31, 2025

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-agentframework/README.md Show resolved Hide resolved

pontemonti previously approved these changes Oct 31, 2025

View reviewed changes

mrunalhirve128 added 2 commits October 31, 2025 10:02

Test

c7baa68

Merge branch 'users/mrunalhirve/AgentFrameworkSDKInPython' of https:/…

e4d7fed

…/github.com/microsoft/Agent365-python into users/mrunalhirve/AgentFrameworkSDKInPython

mrunalhirve128 dismissed pontemonti’s stale review via e4d7fed October 31, 2025 17:02

Ruff format

6feac83

Copilot AI review requested due to automatic review settings October 31, 2025 17:05

Copilot AI reviewed Oct 31, 2025

View reviewed changes

change

06d695f

pontemonti approved these changes Oct 31, 2025

View reviewed changes

mrunalhirve128 merged commit 7d7ae9c into main Oct 31, 2025
8 checks passed

pontemonti deleted the users/mrunalhirve/AgentFrameworkSDKInPython branch December 5, 2025 17:15

Conversation

mrunalhirve128 commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mrunalhirve128 commented Oct 29, 2025 •

edited

Loading