-
Notifications
You must be signed in to change notification settings - Fork 12
Add Python SDK support for new lifecycle event types #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,14 @@ class AgentLifecycleEvent(str, Enum): | |
| USERWORKLOADONBOARDINGUPDATED: Event triggered when a user's workload | ||
| onboarding status is updated. | ||
| USERDELETED: Event triggered when an agentic user identity is deleted. | ||
| USERUNDELETED: Event triggered when an agentic user identity is un-deleted. | ||
| USERUPDATED: Event triggered when an agentic user identity is updated. | ||
| USERMANAGERUPDATED: Event triggered when an agentic user's manager is updated. | ||
| """ | ||
|
|
||
| USERCREATED = "agenticuseridentitycreated" | ||
| USERWORKLOADONBOARDINGUPDATED = "agenticuserworkloadonboardingupdated" | ||
| USERDELETED = "agenticuseridentitydeleted" | ||
| USERDELETED = "agenticuserdeleted" | ||
| USERUNDELETED = "agenticuserundeleted" | ||
|
Comment on lines
24
to
+26
|
||
| USERUPDATED = "agenticuseridentityupdated" | ||
| USERMANAGERUPDATED = "agenticusermanagerupdated" | ||
eddie-lee-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on_user_undeletedreturnsself.on_lifecycle_notification(...), butAgentNotificationdoesn’t define anon_lifecycle_notificationmethod anywhere in this module (onlyon_agent_lifecycle_notification). This will raiseAttributeErrorwhen the decorator is used. Either implementon_lifecycle_notification(possibly as an alias/wrapper) or update these convenience methods to call the correct existing lifecycle registration method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not quite sure why this comment was generated, there are existing "on_..." methods that call self.on_lifecycle_notification(...)