-
Notifications
You must be signed in to change notification settings - Fork 11
fix: MOS token device code fallback for macOS/Linux + remove dead AzureWebAppCreator #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sellakumaran
merged 2 commits into
main
from
users/sellak/fix-mos-token-macos-platform-error
Mar 9, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/MsalHelper.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| using Microsoft.Extensions.Logging; | ||
| using Microsoft.Identity.Client; | ||
|
|
||
| namespace Microsoft.Agents.A365.DevTools.Cli.Helpers; | ||
|
|
||
| /// <summary> | ||
| /// Shared helpers for MSAL-based authentication flows used across multiple services. | ||
| /// </summary> | ||
| public static class MsalHelper | ||
| { | ||
| /// <summary> | ||
| /// Creates the standard MSAL device code callback that logs the verification URL and user code. | ||
| /// Shared across all interactive auth flows so the device code prompt is consistent. | ||
| /// </summary> | ||
| /// <param name="logger">Optional logger. When null, falls back to <see cref="Console.Error"/>.</param> | ||
| public static Func<DeviceCodeResult, Task> CreateDeviceCodeCallback(ILogger? logger) | ||
| { | ||
| return deviceCode => | ||
| { | ||
| if (logger != null) | ||
| { | ||
| logger.LogInformation(""); | ||
| logger.LogInformation("=========================================================================="); | ||
| logger.LogInformation("To sign in, use a web browser to open the page:"); | ||
| logger.LogInformation(" {VerificationUrl}", deviceCode.VerificationUrl); | ||
| logger.LogInformation(""); | ||
| logger.LogInformation("And enter the code: {UserCode}", deviceCode.UserCode); | ||
| logger.LogInformation("=========================================================================="); | ||
| logger.LogInformation(""); | ||
| } | ||
| else | ||
| { | ||
| Console.Error.WriteLine(); | ||
| Console.Error.WriteLine("=========================================================================="); | ||
| Console.Error.WriteLine("To sign in, use a web browser to open the page:"); | ||
| Console.Error.WriteLine($" {deviceCode.VerificationUrl}"); | ||
| Console.Error.WriteLine(); | ||
| Console.Error.WriteLine($"And enter the code: {deviceCode.UserCode}"); | ||
| Console.Error.WriteLine("=========================================================================="); | ||
| Console.Error.WriteLine(); | ||
| } | ||
| return Task.CompletedTask; | ||
| }; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 0 additions & 87 deletions
87
src/Microsoft.Agents.A365.DevTools.Cli/Services/AzureWebAppCreator.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.