Skip to content

feat: CMS autoTriage improvements and review feedback#283

Open
RossHastie wants to merge 5 commits intomicrosoft:mainfrom
RossHastie:feature/42-feature-remediation
Open

feat: CMS autoTriage improvements and review feedback#283
RossHastie wants to merge 5 commits intomicrosoft:mainfrom
RossHastie:feature/42-feature-remediation

Conversation

@RossHastie
Copy link
Copy Markdown

Summary

  • autoTriage code quality: Extracted 3 helpers from 360-line triage_issues() function, deduplicated constants into constants.py, replaced emojis with text labels, added type hints
  • Rate limiting: Rolling 60-second window for LLM API calls with LLM_MAX_CALLS_PER_MINUTE config
  • Bounded caching: Replaced @lru_cache on instance methods with bounded dict cache (CACHE_MAX_ENTRIES=100) and two-phase eviction
  • Input truncation: MAX_ISSUE_TITLE_LENGTH=200, MAX_ISSUE_BODY_LENGTH=2000 applied uniformly
  • GitHub Enterprise support: urlparse-based URL handling instead of hardcoded regex
  • Review feedback documentation: 6 independent code review reports + consolidated findings register + verification report
  • Dependabot: Added .github/dependabot.yml for automated dependency updates

23 files changed, +4,607/-292 lines

Test plan

  • Verify autoTriage service initialises without errors
  • Verify rate limiter throttles after configured max calls
  • Verify bounded cache evicts oldest entries beyond 100
  • Verify long issue titles/bodies are truncated at boundaries
  • Verify GitHub Enterprise URLs are parsed correctly

🤖 Generated with Claude Code

autoTriage: extract shared constants, refactor 360-line triage_issues into
3 helpers (212 lines), add type hints, replace emojis with text indicators,
bounded caching with eviction, LLM rate limiting, input truncation, pin
dependencies, add Dependabot config, GitHub Enterprise URL support.

Feedback: add all CMS V1 review reports and consolidated findings register
from 4 independent code review agents (security, architecture, code quality,
evaluation methodology).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 22, 2026 16:55
@RossHastie RossHastie requested review from a team as code owners February 22, 2026 16:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the autoTriage tooling by refactoring the intake pipeline, adding LLM call protections (rate limiting + input truncation/sanitization), improving caching behavior in GitHub API wrappers, and aligning user-facing output with repo conventions. It also adds operational documentation artifacts and enables Dependabot for Python dependency updates.

Changes:

  • Refactors triage_issues() by extracting helpers and standardizing outputs (including removing emoji status markers in autoTriage outputs).
  • Adds LLM request hardening: rolling-window rate limiter, consistent input truncation, and user-content sanitization before prompt interpolation.
  • Replaces @lru_cache usage on GitHubService instance methods with a bounded, TTL-based module cache; pins Python dependencies and adds Dependabot config.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
scripts/cli/install-cli.ps1 Adds strict mode, prerequisite validation, and comment-based help for CLI installation script.
scripts/cli/Auth/New-Agent365ToolsServicePrincipalProdPublic.ps1 Improves robustness via strict mode and error handling for module install/import.
autoTriage/services/teams_service.py Replaces emoji markers in Teams Adaptive Cards with text labels.
autoTriage/services/llm_service.py Adds sanitization, truncation, and process-wide rate limiting; updates prompt formatting.
autoTriage/services/intake_service.py Adds URL parsing via urlparse, refactors triage orchestration into helpers, and applies sanitization in Copilot paths.
autoTriage/services/github_service.py Introduces bounded cache eviction and migrates repository label caching to TTL cache.
autoTriage/requirements.txt Pins dependency versions and adds guidance for hash verification.
autoTriage/constants.py Introduces shared constants module (e.g., contributors-to-show limit).
Feedback/*.md Adds multiple review reports, consolidated findings, and verification documentation.
.github/dependabot.yml Enables weekly Dependabot updates for /autoTriage pip dependencies.

Ross Hastie and others added 3 commits February 22, 2026 20:01
- Sanitise exceptions to prevent token/key leakage in logs
- Add XML entity escaping to defend against prompt injection
- Bound _repo_cache with FIFO eviction at CACHE_MAX_ENTRIES
- Guard rate limiter against negative sleep times
- Validate LLM JSON output against allowlisted type/priority enums

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…rovements

- Extract sanitise_exception/sanitise_user_content to utils/sanitise.py so
  they are shared across services rather than imported as private symbols
- Fix XML escaping order: & escaped before < and > to prevent double-encoding
- Fix Bearer token redaction order: Bearer regex runs before key=value regex
  so the full JWT value is captured before the header name consumes it
- Add threading.Lock to RateLimiter for safe concurrent Azure Functions use
- Add github_host propagation through _fetch_issues_to_triage so GHE issue
  URLs in IssueClassification point at the correct server, not github.com
- Add ValueError guard when both issue_url and issue_numbers are provided
- Replace CONFIDENTIAL classification markers with INTERNAL in Feedback files
- Replace emoji character in PowerShell script with plain-text WARNING label
- Add 39 tests: sanitise utils, RateLimiter, _parse_issue_url (incl. GHE),
  and _fetch_issues_to_triage mutual exclusion guard

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Plumb GHE hostname through GitHubService: add github_host parameter to
  __init__ and configure PyGithub base_url for non-github.com hosts;
  triage_issues extracts the host from issue_url before constructing the
  service so API calls reach the correct GHE endpoint
- Defensive parsing for LLM_MAX_CALLS_PER_MINUTE: wrap int() in try/except
  and fall back to the default (60) with a warning rather than crashing at
  import time when the env var contains a non-integer value

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 28, 2026 00:00
Keep main's bash-delegation approach (install-cli.ps1 → install-cli.sh)
and retain the PR branch's synopsis header and strict-mode improvements.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sellakumaran sellakumaran enabled auto-merge (squash) March 28, 2026 00:02
@microsoft-github-policy-service
Copy link
Copy Markdown

@RossHastie please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 29 changed files in this pull request and generated 1 comment.

Comment on lines +48 to +66
def __init__(self, max_calls_per_minute: int = 60):
self._max_calls = max_calls_per_minute
self._calls: List[float] = []
self._lock = threading.Lock()

def wait_if_needed(self) -> None:
"""Block until a call is allowed under the rate limit."""
with self._lock:
now = time.monotonic()
# Remove timestamps that have aged out of the 60-second window.
self._calls = [t for t in self._calls if now - t < 60]

if len(self._calls) >= self._max_calls:
# Sleep until the oldest recorded call falls outside the window.
# max(0, ...) guards against a negative value that could arise from
# clock skew or a race where the window entry just aged out between
# the list-comprehension above and this calculation.
sleep_time = max(0, 60 - (now - self._calls[0]))
if sleep_time > 0:
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RateLimiter doesn't validate max_calls_per_minute. If LLM_MAX_CALLS_PER_MINUTE is set to 0 (or a negative value), wait_if_needed() will enter the limit branch with an empty _calls list and then access self._calls[0], raising IndexError. Consider enforcing max_calls_per_minute >= 1 (or treating 0 as 'disabled' and skipping limiting).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants