Skip to content

Refactor pod readiness polling to use wait_for_ready helper #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor pod readiness polling to use wait_for_ready helper #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5718fe9
Initial plan
Copilot Jan 14, 2026
021e184
Refactor pod readiness polling to use wait_for_ready helper
Copilot Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 8 additions & 29 deletions aiopslab/orchestrator/problems/misconfig_app/misconfig_app_hotel_res.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

"""MongoDB storage user unregistered problem in the HotelReservation application."""

from time import sleep
from typing import Any

from aiopslab.orchestrator.tasks import *
Expand Down Expand Up @@ -167,32 +166,12 @@ def eval(self, soln: Any, trace: list[SessionItem], duration: float) -> dict:
super().eval(soln, trace, duration)

# Check if all services (not only faulty service) is back to normal (Running)
all_normal = True
# Polling for 1 minute to check if all services are back to normal
for _ in range(12): # 5 seconds interval, 12 times, total 1 minute
pod_list = self.kubectl.list_pods(self.namespace)
for pod in pod_list.items:
# Check container statuses
for container_status in pod.status.container_statuses:
if container_status.state.waiting:
reason = container_status.state.waiting.reason
if reason in ["CrashLoopBackOff", "Error", "ImagePullBackOff", "ErrImagePull"]:
print(f"Container {container_status.name} is in error state: {reason}")
all_normal = False
elif container_status.state.terminated and container_status.state.terminated.reason != "Completed":
print(f"Container {container_status.name} is terminated with reason: {container_status.state.terminated.reason}")
all_normal = False
elif not container_status.ready:
print(f"Container {container_status.name} is not ready")
all_normal = False

if not all_normal:
break

if not all_normal:
break
# Wait for 5 seconds before checking again
sleep(5)

self.results["success"] = all_normal
# Use wait_for_ready helper to poll for pod readiness
try:
self.kubectl.wait_for_ready(self.namespace, sleep=5, max_wait=60)
self.results["success"] = True
except Exception as e:
print(f"Pods are not all ready: {e}")
self.results["success"] = False

return self.results