Skip to content

Fix Prometheus Helm.status crash due to invalid chart_path argument #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rahuldrabit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Prometheus Helm.status crash due to invalid chart_path argument #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d40f9e1
Fix Helm.status argument mismatch in Prometheus telemetry
Rahuldrabit Jan 10, 2026
794a766
Fix Helm release check for Prometheus by using lowercase release name
Rahuldrabit Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion aiopslab/service/telemetry/prometheus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ def _pvc_exists(self, pvc_name: str) -> bool:
def _is_prometheus_running(self) -> bool:
"""Check if Prometheus Helm release is deployed."""
try:
status_output = Helm.status(**self.helm_configs)
status_output = Helm.status(
release_name=self.name.lower(),
namespace=self.namespace,
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with how Helm.install() and Helm.uninstall() are called (using self.helm_configs), the namespace parameter should also use self.helm_configs["namespace"] instead of self.namespace. While both currently have the same value ("observe"), using helm_configs ensures all Helm operations use the same source of configuration and prevents potential inconsistencies if the metadata structure changes.

Suggested change
namespace=self.namespace,
namespace=self.helm_configs["namespace"],

Copilot uses AI. Check for mistakes.
)
for line in status_output.splitlines():
if line.strip().startswith("STATUS:"):
status_value = line.split(":", 1)[1].strip().lower()
Expand All @@ -137,3 +140,4 @@ def _is_prometheus_running(self) -> bool:
except Exception as e:
logging.exception(f"Unexpected error while checking Prometheus status: {e}")
return False