Provide a way to disable health checks with configuration#337
Open
xstefank wants to merge 1 commit intomicroprofile:mainfrom
Open
Provide a way to disable health checks with configuration#337xstefank wants to merge 1 commit intomicroprofile:mainfrom
xstefank wants to merge 1 commit intomicroprofile:mainfrom
Conversation
Member
Author
|
@fabiobrz also please review |
pgunapal
requested changes
Feb 7, 2025
tck/src/main/java/org/eclipse/microprofile/health/tck/DefaultEmptyResponseConfigTest.java
Show resolved
Hide resolved
fabiobrz
reviewed
Feb 7, 2025
fabiobrz
left a comment
fabiobrz
left a comment
There was a problem hiding this comment.
Thanks @xstefank - changes LGTM, although when getting to the TCK test I intuitively expected for more checks of the same category to be present (e.g.: multiple readiness checks), and one (or more) of those to be disabled.
But that doesn't actually change a thing in the effectiveness of the test, so I'll leave any additional consideration to you.
xstefank
force-pushed
the
disabling-checks-335
branch
from
0e4f9e9 to
9360417
Compare
Member
Author
|
@fabiobrz I decided to refactor TCK a little after this is merged. I will add more tests for this issue when I will do the refactor. So please approve it like this and we will discuss more in the new PR. |
fabiobrz
approved these changes
Feb 10, 2025
xstefank
force-pushed
the
disabling-checks-335
branch
from
9360417 to
272893e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335