Skip to content

Copy JavaPoet#10

Merged
dstepanov merged 1 commit intomasterfrom
javapoet
Oct 18, 2023
Merged

Copy JavaPoet#10
dstepanov merged 1 commit intomasterfrom
javapoet

Conversation

@dstepanov
Copy link
Collaborator

To support records etc
square/javapoet#981

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little uncomfortable at the idea of copying the entire JavaPoet library here, it's going to make maintenance harder. Also if we do so and that we build a wrapper on top of it and KotlinPoet, maybe it's redundant altogether...

@dstepanov
Copy link
Collaborator Author

What do you mean by redundant? JavaPoet is not maintained anymore but KotlinPort I think it is

@melix
Copy link
Contributor

melix commented Oct 17, 2023

I mean that if we build something on top of both JavaPoet and KotlinPoet, and that we have to copy the JavaPoet implementation in any case, we might be better building a model that can generate both Java and Kotlin code directly, inspired from these.

@dstepanov
Copy link
Collaborator Author

Java and Kotlin poet have different APIs, the other option would be use the Java poet API and convert it to Kotlin, I don’t think that’s a good idea, we don’t really want to use very opinionated Java Poet API

@dstepanov dstepanov merged commit 51658d5 into master Oct 18, 2023
@zzBBc
Copy link

zzBBc commented Oct 25, 2023

I'm the author of this PR square/javapoet#981 with idea support gen record.

I want to contribute more about javapoet on your project or any related task.

Please let me know if you agree with my request.

@dstepanov dstepanov deleted the javapoet branch October 25, 2023 10:32
@dstepanov
Copy link
Collaborator Author

I did include records support from https://github.com/FabricMC/javapoet repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants