Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
melix
left a comment
There was a problem hiding this comment.
I'm a little uncomfortable at the idea of copying the entire JavaPoet library here, it's going to make maintenance harder. Also if we do so and that we build a wrapper on top of it and KotlinPoet, maybe it's redundant altogether...
|
What do you mean by redundant? JavaPoet is not maintained anymore but KotlinPort I think it is |
|
I mean that if we build something on top of both JavaPoet and KotlinPoet, and that we have to copy the JavaPoet implementation in any case, we might be better building a model that can generate both Java and Kotlin code directly, inspired from these. |
|
Java and Kotlin poet have different APIs, the other option would be use the Java poet API and convert it to Kotlin, I don’t think that’s a good idea, we don’t really want to use very opinionated Java Poet API |
|
I'm the author of this PR square/javapoet#981 with idea support gen record. I want to contribute more about javapoet on your project or any related task. Please let me know if you agree with my request. |
|
I did include records support from https://github.com/FabricMC/javapoet repo |








To support records etc
square/javapoet#981