Layouts #9
Open
Layouts #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a list style of "none" for all list items within the #post-list is overly broad. We should only affect the direct child list items so that any <li> tags within a post retain their proper list style.
There cannot be more than one `id=wrapper` on the resulting HTML page
Add microformat markup to `post-item.html` Alsö, whitespace
It is not valid to put `<span>`s inside a `<ul>` not inside a `<li>`. See here for CSS info: https://stackoverflow.com/questions/20736211/adding-hr-using-the-after-selector
w3c expects `<article>`s to have `<header>`s, it seems
Alsö, dont use `id=wrapper` and add a couple of `class=…` from the default theme…because…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve whitespace, add a
.editorconfigfile to encourage consistent whitespace, add some microformats markup in a few places, and reduce unnecessary HTML elements.I'd alsö like to move some fixes to the default theme and hopefully simplify this theme a little.
EDIT: the changes to the
datetimeattributes are because the w3c validator complains they're not valid. I think it's just really really upset about the space before the time zone offset?