Conversation
TuomasBorman
requested changes
Jan 12, 2026
Contributor
TuomasBorman
left a comment
TuomasBorman
left a comment
There was a problem hiding this comment.
The resulting plot looks good!
Comment on lines
+326
to
+328
| .plot_hist_bar(df, geom_bar, TRUE, color, fill, alpha, scales, | ||
| position, ...) | ||
| } |
Contributor
There was a problem hiding this comment.
End every function with return()
Comment on lines
+337
to
+339
| if (!is.null(fill_by)) { | ||
| mapping <- aes(x = value, fill = .data[[fill_by]]) | ||
| } |
Contributor
There was a problem hiding this comment.
Use the same formatting as in rest of the package
Comment on lines
+314
to
+316
| geom_fun <- switch(layout, histogram = geom_histogram, density = geom_density) | ||
| .plot_hist_bar(df, geom_fun, layout == "histogram", color, fill, | ||
| alpha, scales, position, ...) |
Contributor
There was a problem hiding this comment.
use_position is redundant. You can overwrite position <- NULL if layout == "density"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #214 +/- ##
==========================================
+ Coverage 57.71% 60.31% +2.60%
==========================================
Files 21 21
Lines 3493 3669 +176
==========================================
+ Hits 2016 2213 +197
+ Misses 1477 1456 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping #195