Skip to content

plotLoadings, sort#189

Draft
TuomasBorman wants to merge 1 commit intodevelfrom
sort_loadings
Draft

plotLoadings, sort#189
TuomasBorman wants to merge 1 commit intodevelfrom
sort_loadings

Conversation

@TuomasBorman
Copy link
Contributor

@TuomasBorman TuomasBorman linked an issue May 3, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 48.48485% with 17 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (750342d) to head (a74b99b).
Report is 6 commits behind head on devel.

Files with missing lines Patch % Lines
R/plotLoadings.R 48.48% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #189      +/-   ##
==========================================
- Coverage   58.76%   58.04%   -0.72%     
==========================================
  Files          20       21       +1     
  Lines        3082     3473     +391     
==========================================
+ Hits         1811     2016     +205     
- Misses       1271     1457     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TuomasBorman TuomasBorman changed the title pålotLoadings, sort plotLoadings, sort May 6, 2025
@TuomasBorman
Copy link
Contributor Author

See the discussion in OMA: microbiome/OMA#146

It might be that getNeatOrder() will be removed and replaced by utilization of seriation package. In that case, this PR must be modified to use seriation package as well. That is rather small change as the functionality for sorting the loadings is already here but must be taken into account.

We could also consider using seriation package here in any case.

@TuomasBorman TuomasBorman marked this pull request as draft May 8, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plotLoadings feature sort

1 participant