feat: add Containerfile and DESCRIPTION#78
feat: add Containerfile and DESCRIPTION#78artur-sannikov wants to merge 1 commit intomicrobiome:develfrom
Conversation
artur-sannikov
force-pushed
the
feat/docker-image
branch
from
4183152 to
86c19a3
Compare
|
@TuomasBorman. The image builds fine and the paper inside the container too. You can check the image here: https://github.com/artur-sannikov/OMA_manuscript/pkgs/container/oma-manuscript |
|
Thank you! I have to check this next week, I will be on holiday Thursday-Friday and too much tasks already for today. Sorry! |
There was a problem hiding this comment.
Are these changes made by you? .tex file is generated by qmd file; the changes in .tex file will be overwritten
There was a problem hiding this comment.
Yep, git blame says that. But I don't recall even opening that file. They can and should be overwritten.
DESCRIPTION
Outdated
| @@ -0,0 +1,41 @@ | |||
| Package: omaManuscript | |||
There was a problem hiding this comment.
Name could be OMA_manuscript as in repo name
Containerfile
Outdated
| R -e "install.packages('remotes', repos = c(CRAN = 'https://cloud.r-project.org'))" && \ | ||
| R -e "remotes::install_deps(dependencies = TRUE)" | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove extra line break
TuomasBorman
left a comment
TuomasBorman
left a comment
There was a problem hiding this comment.
See comments. Looks good, I think!
TuomasBorman
left a comment
TuomasBorman
left a comment
There was a problem hiding this comment.
Can you remove all commits related to manuscript.pdf, manuscript.tex and figures? Not sure what are those changes as they are not related to docker. Otherwise seems good
artur-sannikov
force-pushed
the
feat/docker-image
branch
3 times, most recently
from
aa67311 to
05c6023
Compare
|
@TuomasBorman, can be merged. |
fix: add missing authors
artur-sannikov
force-pushed
the
feat/docker-image
branch
from
2753281 to
37e42e5
Compare
|
Authors were missing in the DESCRIPTION file. |
2 participants
See #68.
The PR introduces Container file to build OCI-compliant container images using the DESCRIPTION file.
TODO:
quarto install tinytexto install when building locally. For some reason, it cannot download the tinytex from remote, even though from inside the container it works