Open
Conversation
Modify the code of Ruler's Updater so that it is polymorphic and utilizes a pure virtual Update function.
As discussed, change the name of sg to sign to be more clear to developers.
Adding mpUpdater and SetUpdater to the ruler. This is assuming that Updater will still be a nested class of Ruler. I will make a later branch that will un-nest Updater and Format from Ruler to give multiple ways to proceed. Quick Fix Removed some faulty code from previous push Update Ruler.h
Also detach ChooseFonts from the Updater because it is completely unrelated quick fix
Clean up ZoomInfo related code, and pull TickOutput and UpdateOutput out of Updater to be alongside TickSizes since they were separate but all serve similar purpose. If migrating them all back into Updater is a good idea, I will do so later
Necessary to add SetUpdater to all rulers
Lots of changes now that Visual Studio functions correctly. Primarily turns Updater from a inner class to a friend class.
Replace all uses of SetUseZoomInfo with SetUpdater
Small edits
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this PR to catalogue mentor comments before interactive rebasing to squash commits that do not compile. All further changes will be on
polymorphic-ruler-version-3.