Skip to content

Ensure uniqueness even when the page has duplicated Ids #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbuezas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure uniqueness even when the page has duplicated Ids #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfcc86a
Ensure uniqueness even when the page has duplicated Ids
dbuezas Oct 9, 2015
e49f1e0
removed semicolons to follow original code-style
dbuezas Oct 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions css-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,14 @@ var trim = require('trim')
, id = elm.getAttribute('id')

if (id) {
list.unshift(tag + '#' + trim(id))
return list
list.unshift( tag + '#' + trim(id) )
var isUnique = rootNode.querySelectorAll(list.join('>')).length === 1
if (isUnique){
return list
} else {
list.shift()
selector.push('#' + trim(id))
}
}

if (className)
Expand All @@ -57,4 +63,4 @@ var trim = require('trim')

module.exports = function (elm, rootNode) {
return path(elm, rootNode, []).join(' > ')
}
}